-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce CH32V203 and WeactStudio CH32V203 Blue Pill plus #87490
base: main
Are you sure you want to change the base?
Conversation
Introduces the Soc for ch32v203 Signed-off-by: Camille BAUD <[email protected]>
Introduce CH32V203 SoC Signed-off-by: Camille BAUD <[email protected]>
Adds CH32V203 support Signed-off-by: Camille BAUD <[email protected]>
Adds CH32V203 to the systick timer driver Signed-off-by: Camille BAUD <[email protected]>
275509a
to
c9b2d89
Compare
drive-push-pull; | ||
slew-rate = "max-speed-10mhz"; | ||
}; | ||
group2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Programming and Debugging | ||
************************* | ||
|
||
Applications for the ``bluepillplus_ch32v203`` board target can be built and flashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applications for the ``bluepillplus_ch32v203`` board target can be built and flashed | |
Applications for the ``bluepillplus_ch32v203`` board can be built and flashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Introduces WeActStudio Blue Pill Plus CH32V203 Signed-off-by: Camille BAUD <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some nits.
|
||
* CLOCK | ||
* :abbr:`GPIO (General Purpose Input Output)` | ||
* :abbr:`NVIC (Nested Vectored Interrupt Controller)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the UART?
* :abbr:`GPIO (General Purpose Input Output)` | ||
* :abbr:`NVIC (Nested Vectored Interrupt Controller)` | ||
|
||
The board is equipped with two LEDs and two Buttons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it's two LEDs, but only one is controllable, and 3 buttons.
Perhaps say "with a user LED and user button in addition to a power LED, reset button, and boot select button."
also s/Button/button/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to update that part, thats from linkw.
|
||
flash0: flash@8000000 { | ||
compatible = "soc-nv-flash"; | ||
reg = <0x08000000 DT_SIZE_K(224)>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
64 K?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, 224K. 64K is the zerowait, CH32V203 has 224K flash,and it's enabled in here (see Vector.S)
config SYS_CLOCK_HW_CYCLES_PER_SEC | ||
default $(dt_node_int_prop_int,/cpus/cpu@0,clock-frequency) | ||
|
||
config MAIN_STACK_SIZE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably drop these. They were added for the CH32V003 as it has 2 KiB of RAM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to update that part anyway, this is awaiting the merge of a couple other things and i havent bothered updating the pr (#87345), this is why this is DNM
Introduces CH32V203 and WeactStudio CH32V203 Blue Pill +
DNM until #87125 and associated fixes and changes are merged.